[Mac] Fix profile getting re-created / IO allowed dcheck with profile menu.

[Mac] Fix profile getting re-created / IO allowed dcheck with profile menu.

BUG=167518
TEST=See bug.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174736

[Alexei Svitkine (slow), 2012-12-24 22:32:32]

I know this needs a test and probably a comment, but wanted to send this off
today. I'll add the test later this week.

[sail, 2012-12-26 18:56:41]

Looks good to me. Adding rsesek who wrote this code.

[Alexei Svitkine (slow), 2012-12-27 19:43:11]

[Mac] Fix profile getting re-created / IO allowed dcheck with profile menu.

BUG=167518
TEST=See bug.

[Alexei Svitkine (slow), 2012-12-27 19:50:39]

I've added a test now and changed the implementation of the fix.

(The previous one resulted in the last profile menu item getting unchecked when
there are no browser windows, even when a profile wasn't deleted. There was a
test against this which failed.)

The new fix is simply an early return and a comment explaining why it makes
sense.

I've added a test that approximates what happens in the bug, but is not exactly
the same, since there's no infrastructure for faking an "unloaded" profile. I'm
not completely happy with it, but the test does hit the bug when run without the
fix.

Let me know if you have any suggestions on how to test this better.

[sail, 2012-12-27 22:49:59]

LGTM!
Can we do anything about making ProfileManager::GetLastUsedProfile() better so
this doesn't happen again?

[Alexei Svitkine (slow), 2012-12-28 15:22:55]

On 2012/12/27 22:49:59, sail wrote:
> LGTM!
> Can we do anything about making ProfileManager::GetLastUsedProfile() better so
> this doesn't happen again?

I've filed a bug about this: http://crbug.com/167761. Probably, the right
solution is to have it so it may return NULL in that case and audit the callers
that they properly handle that.

[Robert Sesek, 2012-12-28 17:36:08]

LGTM

[commit-bot: I haz the power, 2012-12-28 17:44:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11661017/7001

[commit-bot: I haz the power, 2012-12-28 19:53:18]

Change committed as 174736