Move VisitorShim from QuicServerSession to QuicSession.

Move VisitorShim from QuicServerSession to QuicSession.

Merge internal change: 40309491


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174544

[jar (doing other things), 2012-12-22 21:45:23]

lgtm

https://codereview.chromium.org/11661002/diff/1/net/quic/quic_session.cc
File net/quic/quic_session.cc (right):

https://codereview.chromium.org/11661002/diff/1/net/quic/quic_session.cc#newc...
net/quic/quic_session.cc:64: visitor_shim_(new VisitorShim(this)),
There used to be a pragma on some platforms that was needed to pass "this" out
so early (prior to completion of a construction). Don't be surprised if you get
an error from this on some platform (but perchance this is no longer needed).

[Ryan Hamilton, 2012-12-22 21:47:08]

Thanks!

https://codereview.chromium.org/11661002/diff/1/net/quic/quic_session.cc
File net/quic/quic_session.cc (right):

https://codereview.chromium.org/11661002/diff/1/net/quic/quic_session.cc#newc...
net/quic/quic_session.cc:64: visitor_shim_(new VisitorShim(this)),
On 2012/12/22 21:45:23, jar wrote:
> There used to be a pragma on some platforms that was needed to pass "this" out
> so early (prior to completion of a construction). Don't be surprised if you
get
> an error from this on some platform (but perchance this is no longer needed).

Good point.  Curious which platform this will trigger on.  Not linux, I suspect
:>

[commit-bot: I haz the power, 2012-12-22 21:59:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/11661002/5001

[commit-bot: I haz the power, 2012-12-23 03:07:26]

Change committed as 174544