Issue 11660028: Add kNumberStringCacheRootIndex into writable_roots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11660028: Add kNumberStringCacheRootIndex into writable_roots (Closed)

Created:
7 years, 12 months ago by haitao.feng

Modified:
7 years, 12 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Add kNumberStringCacheRootIndex into writable_roots Committed: https://code.google.com/p/v8/source/detail?r=13278

Patch Set 1 #

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/heap.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

number_string_cache might be re-set by Heap::AllocateFullSizeNumberStringCache after initialization.

7 years, 12 months ago (2012-12-26 05:27:35 UTC) #1

Yang

On 2012/12/26 05:27:35, haitao.feng wrote: > number_string_cache might be re-set by Heap::AllocateFullSizeNumberStringCache > after initialization. ...

7 years, 12 months ago (2012-12-27 10:08:12 UTC) #2

Yang

7 years, 12 months ago (2012-12-27 10:11:40 UTC) #3

Message was sent while issue was closed.

On 2012/12/27 10:08:12, Yang wrote:
> On 2012/12/26 05:27:35, haitao.feng wrote:
> > number_string_cache might be re-set by
Heap::AllocateFullSizeNumberStringCache
> > after initialization.
> 
> LGTM. Landing.

Nice catch btw!

Expand Messages | Collapse Messages