Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4655)

Unified Diff: chrome/common/extensions/extension.h

Issue 11660016: Move the parsing of "chrome_url_overrides" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index d2fd4500e3f52b0d3e1056aa47cba40cb72b589e..0b968e6fd16fc070a7515d02f10497e25e8d71a2 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -67,7 +67,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
struct InstallWarning;
struct ManifestData;
- typedef std::map<const std::string, GURL> URLOverrideMap;
typedef std::vector<std::string> ScriptingWhitelist;
typedef std::vector<linked_ptr<FileBrowserHandler> > FileBrowserHandlerList;
typedef std::vector<InstallWarning> InstallWarningVector;
@@ -768,9 +767,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
return manifest_.get();
}
const std::string default_locale() const { return default_locale_; }
- const URLOverrideMap& GetChromeURLOverrides() const {
- return chrome_url_overrides_;
- }
bool incognito_split_mode() const { return incognito_split_mode_; }
bool offline_enabled() const { return offline_enabled_; }
const std::vector<TtsVoice>& tts_voices() const { return tts_voices_; }
@@ -798,6 +794,7 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool is_extension() const;
bool is_storage_isolated() const { return is_storage_isolated_; }
bool can_be_incognito_enabled() const;
+ void AddWebExtentPattern(const URLPattern& pattern);
const URLPatternSet& web_extent() const { return extent_; }
const std::string& launch_local_path() const { return launch_local_path_; }
const std::string& launch_web_url() const { return launch_web_url_; }
@@ -964,7 +961,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// Helper method to load an FileBrowserHandler from manifest.
FileBrowserHandler* LoadFileBrowserHandler(
const base::DictionaryValue* file_browser_handlers, string16* error);
- bool LoadChromeURLOverrides(string16* error);
bool LoadTextToSpeechVoices(string16* error);
bool LoadIncognitoMode(string16* error);
bool LoadContentSecurityPolicy(string16* error);
@@ -1209,10 +1205,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// Set to true at the end of InitValue when initialization is finished.
bool finished_parsing_manifest_;
- // A map of chrome:// hostnames (newtab, downloads, etc.) to Extension URLs
- // which override the handling of those URLs. (see ExtensionOverrideUI).
- URLOverrideMap chrome_url_overrides_;
-
// Whether this extension requests isolated storage.
bool is_storage_isolated_;

Powered by Google App Engine
This is Rietveld 408576698