Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Unified Diff: chrome/browser/extensions/api/url_overrides/url_overrides_api.h

Issue 11660016: Move the parsing of "chrome_url_overrides" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/url_overrides/url_overrides_api.h
diff --git a/chrome/browser/extensions/api/url_overrides/url_overrides_api.h b/chrome/browser/extensions/api/url_overrides/url_overrides_api.h
new file mode 100644
index 0000000000000000000000000000000000000000..e0573949f423801ee417a0bb50a21b80dba9d7fb
--- /dev/null
+++ b/chrome/browser/extensions/api/url_overrides/url_overrides_api.h
@@ -0,0 +1,37 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_URL_OVERRIDES_URL_OVERRIDES_API_H_
+#define CHROME_BROWSER_EXTENSIONS_API_URL_OVERRIDES_URL_OVERRIDES_API_H_
+
+#include "base/basictypes.h"
+#include "chrome/browser/profiles/profile_keyed_service.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+
+class Profile;
+
+namespace extensions {
+
+class URLOverridesAPI : public ProfileKeyedService,
+ public content::NotificationObserver {
Joe Thomas 2012/12/22 01:25:57 There are no URLOverrides APIs in extensions, but
Yoyo Zhou 2012/12/28 03:59:45 Seems reasonable to have this be separated out, bu
Yoyo Zhou 2013/01/03 22:36:03 My vote is still to leave this in chrome/browser/e
Joe Thomas 2013/01/04 23:36:11 I made it part of ManifestURLParser in chrome/brow
+ public:
+ explicit URLOverridesAPI(Profile* profile);
+ virtual ~URLOverridesAPI();
+
+ // content::NotificationObserver implementation.
+ virtual void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) OVERRIDE;
+
+ private:
+ Profile* const profile_;
+ content::NotificationRegistrar registrar_;
+
+ DISALLOW_COPY_AND_ASSIGN(URLOverridesAPI);
+};
+
+} // namespace extensions
+
+#endif // CHROME_BROWSER_EXTENSIONS_API_URL_OVERRIDES_URL_OVERRIDES_API_H_

Powered by Google App Engine
This is Rietveld 408576698