Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 11660016: Move the parsing of "chrome_url_overrides" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments addressed Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index b89c7abd0f4de03548ac29d06478f88b2372b85f..f6522319849a2b45ba763cf6f9af0df24aa12c49 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -52,7 +52,6 @@
#include "chrome/browser/extensions/extension_special_storage_policy.h"
#include "chrome/browser/extensions/extension_sync_data.h"
#include "chrome/browser/extensions/extension_system.h"
-#include "chrome/browser/extensions/extension_web_ui.h"
#include "chrome/browser/extensions/external_install_ui.h"
#include "chrome/browser/extensions/external_provider_impl.h"
#include "chrome/browser/extensions/external_provider_interface.h"
@@ -1069,9 +1068,6 @@ void ExtensionService::NotifyExtensionLoaded(const Extension* extension) {
UpdateActiveExtensionsInCrashReporter();
- ExtensionWebUI::RegisterChromeURLOverrides(
- profile_, extension->GetChromeURLOverrides());
-
// If the extension has permission to load chrome://favicon/ resources we need
// to make sure that the FaviconSource is registered with the
// ChromeURLDataManager.
@@ -1163,9 +1159,6 @@ void ExtensionService::NotifyExtensionUnloaded(
profile_->GetExtensionSpecialStoragePolicy()->
RevokeRightsForExtension(extension);
- ExtensionWebUI::UnregisterChromeURLOverrides(
- profile_, extension->GetChromeURLOverrides());
-
#if defined(OS_CHROMEOS)
// Revoke external file access to third party extensions.
fileapi::FileSystemContext* filesystem_context =

Powered by Google App Engine
This is Rietveld 408576698