components/keyed_service/ios/browser_state_keyed_service_factory.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/keyed_service/ios/browser_state_keyed_service_factory.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc ('K') | « components/keyed_service/ios/browser_state_keyed_service_factory.h ('k') | extensions/browser/api/api_resource_manager.h » ('j') | extensions/browser/api/storage/storage_api_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/keyed_service/ios/browser_state_keyed_service_factory.cc

diff --git a/components/keyed_service/ios/browser_state_keyed_service_factory.cc b/components/keyed_service/ios/browser_state_keyed_service_factory.cc

index c5279912454907fc1e9fdaf74e7abe6a3668540a..7c75278f81efb92e03e9251b033023f53b92efe1 100644

--- a/components/keyed_service/ios/browser_state_keyed_service_factory.cc

+++ b/components/keyed_service/ios/browser_state_keyed_service_factory.cc

@@ -74,9 +74,13 @@ void BrowserStateKeyedServiceFactory::BrowserStateDestroyed(

KeyedServiceFactory::ContextDestroyed(context);

}

-KeyedService* BrowserStateKeyedServiceFactory::BuildServiceInstanceFor(

+scoped_ptr<KeyedService>

+BrowserStateKeyedServiceFactory::BuildServiceInstanceFor(

base::SupportsUserData* context) const {

- return BuildServiceInstanceFor(static_cast<web::BrowserState*>(context));

+ // TODO(isherman): The wrapped BuildServiceInstanceFor() should return a

+ // scoped_ptr as well.

+ return make_scoped_ptr(

+ BuildServiceInstanceFor(static_cast<web::BrowserState*>(context)));

}

bool BrowserStateKeyedServiceFactory::IsOffTheRecord(