chrome/browser/sync/profile_sync_service_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc ('K') | « chrome/browser/sync/profile_sync_service_typed_url_unittest.cc ('k') | chrome/browser/sync/startup_controller_unittest.cc » ('j') | extensions/browser/api/storage/storage_api_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_unittest.cc b/chrome/browser/sync/profile_sync_service_unittest.cc

index d8cf8c2daf81d6e1e3ee98702189b3787cfc50b6..6c7dc78ecf6ceb4458445b90533c09728923495c 100644

--- a/chrome/browser/sync/profile_sync_service_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_unittest.cc

@@ -162,11 +162,11 @@ ACTION_P(ReturnNewMockHostCollectDeleteDirParam, delete_dir_param) {

delete_dir_param);

}

-KeyedService* BuildFakeProfileInvalidationProvider(

+scoped_ptr<KeyedService> BuildFakeProfileInvalidationProvider(

content::BrowserContext* context) {

- return new invalidation::ProfileInvalidationProvider(

+ return make_scoped_ptr(new invalidation::ProfileInvalidationProvider(

scoped_ptr<invalidation::InvalidationService>(

- new invalidation::FakeInvalidationService));

+ new invalidation::FakeInvalidationService)));

}

// A test harness that uses a real ProfileSyncService and in most cases a