Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6126)

Unified Diff: chrome/browser/signin/fake_signin_manager.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/fake_signin_manager.cc
diff --git a/chrome/browser/signin/fake_signin_manager.cc b/chrome/browser/signin/fake_signin_manager.cc
index 6cc2902ae03f0233cbf56a2fcb8b1d46d9a44612..f81b4b48bf467e8cecb3493bab59776ccdd4685f 100644
--- a/chrome/browser/signin/fake_signin_manager.cc
+++ b/chrome/browser/signin/fake_signin_manager.cc
@@ -26,18 +26,19 @@ FakeSigninManagerBase::~FakeSigninManagerBase() {
}
// static
-KeyedService* FakeSigninManagerBase::Build(content::BrowserContext* context) {
- SigninManagerBase* manager;
+scoped_ptr<KeyedService> FakeSigninManagerBase::Build(
+ content::BrowserContext* context) {
+ scoped_ptr<SigninManagerBase> manager;
Profile* profile = static_cast<Profile*>(context);
#if defined(OS_CHROMEOS)
- manager = new FakeSigninManagerBase(profile);
+ manager.reset(new FakeSigninManagerBase(profile));
#else
- manager = new FakeSigninManager(profile);
+ manager.reset(new FakeSigninManager(profile));
#endif
manager->Initialize(NULL);
SigninManagerFactory::GetInstance()
- ->NotifyObserversOfSigninManagerCreationForTesting(manager);
- return manager;
+ ->NotifyObserversOfSigninManagerCreationForTesting(manager.get());
+ return manager.Pass();
}
#if !defined (OS_CHROMEOS)

Powered by Google App Engine
This is Rietveld 408576698