chrome/browser/signin/fake_gaia_cookie_manager_service.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/fake_gaia_cookie_manager_service.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc ('K') | « chrome/browser/signin/fake_gaia_cookie_manager_service.h ('k') | chrome/browser/signin/fake_profile_oauth2_token_service_builder.h » ('j') | extensions/browser/api/storage/storage_api_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/fake_gaia_cookie_manager_service.cc

diff --git a/chrome/browser/signin/fake_gaia_cookie_manager_service.cc b/chrome/browser/signin/fake_gaia_cookie_manager_service.cc

index 4c767d06ba559b848b67f23b1316bfa87209d684..7d04cfb7be5bed702ed7c2692d4a08f6ed3899fe 100644

--- a/chrome/browser/signin/fake_gaia_cookie_manager_service.cc

+++ b/chrome/browser/signin/fake_gaia_cookie_manager_service.cc

@@ -111,12 +111,11 @@ void FakeGaiaCookieManagerService::SetListAccountsResponseTwoAccountsWithExpiry(

}

// static

-KeyedService* FakeGaiaCookieManagerService::Build(

+scoped_ptr<KeyedService> FakeGaiaCookieManagerService::Build(

content::BrowserContext* context) {

Profile* profile = Profile::FromBrowserContext(context);

- FakeGaiaCookieManagerService* service = new FakeGaiaCookieManagerService(

+ return make_scoped_ptr(new FakeGaiaCookieManagerService(

ProfileOAuth2TokenServiceFactory::GetForProfile(profile),

GaiaConstants::kChromeSource,

- ChromeSigninClientFactory::GetForProfile(profile));

- return service;

+ ChromeSigninClientFactory::GetForProfile(profile)));

}