chrome/browser/services/gcm/fake_gcm_profile_service.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/fake_gcm_profile_service.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc ('K') | « chrome/browser/services/gcm/fake_gcm_profile_service.h ('k') | chrome/browser/services/gcm/gcm_profile_service_unittest.cc » ('j') | chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/services/gcm/fake_gcm_profile_service.cc

diff --git a/chrome/browser/services/gcm/fake_gcm_profile_service.cc b/chrome/browser/services/gcm/fake_gcm_profile_service.cc

index e1926a3b4539a3b99c5364fbd9227cc330957bdd..a1b5e3c24ee68faed00c89a3d93a2b237c387ef9 100644

--- a/chrome/browser/services/gcm/fake_gcm_profile_service.cc

+++ b/chrome/browser/services/gcm/fake_gcm_profile_service.cc

@@ -105,11 +105,12 @@ void CustomFakeGCMDriver::OnSendFinished(const std::string& app_id,

} // namespace

// static

-KeyedService* FakeGCMProfileService::Build(content::BrowserContext* context) {

+scoped_ptr<KeyedService> FakeGCMProfileService::Build(

+ content::BrowserContext* context) {

Profile* profile = static_cast<Profile*>(context);

- FakeGCMProfileService* service = new FakeGCMProfileService(profile);

- service->SetDriverForTesting(new CustomFakeGCMDriver(service));

- return service;

+ scoped_ptr<FakeGCMProfileService> service(new FakeGCMProfileService(profile));

+ service->SetDriverForTesting(new CustomFakeGCMDriver(service.get()));

+ return service.Pass();

}

FakeGCMProfileService::FakeGCMProfileService(Profile* profile)