chrome/browser/extensions/api/socket/socket_api_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/socket_api_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc ('K') | « chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc ('k') | chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc » ('j') | chrome/browser/extensions/extension_garbage_collector_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/socket/socket_api_unittest.cc

diff --git a/chrome/browser/extensions/api/socket/socket_api_unittest.cc b/chrome/browser/extensions/api/socket/socket_api_unittest.cc

index 7634f1e9a17fe3990775fcabfa427ee58238a663..00447a8d7e5451cdf61fa84c7c8a37f7521131bf 100644

--- a/chrome/browser/extensions/api/socket/socket_api_unittest.cc

+++ b/chrome/browser/extensions/api/socket/socket_api_unittest.cc

@@ -2,6 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "base/memory/scoped_ptr.h"

#include "base/values.h"

#include "chrome/browser/browser_process_impl.h"

#include "chrome/browser/extensions/extension_api_unittest.h"

@@ -16,7 +17,8 @@

namespace extensions {

-KeyedService* ApiResourceManagerTestFactory(content::BrowserContext* context) {

+scoped_ptr<KeyedService> ApiResourceManagerTestFactory(

+ content::BrowserContext* context) {

content::BrowserThread::ID id;

CHECK(content::BrowserThread::GetCurrentThreadIdentifier(&id));

return ApiResourceManager<Socket>::CreateApiResourceManagerForTest(context,