chrome/browser/extensions/api/networking_private/networking_private_apitest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/mdns/mdns_api_unittest.cc ('K') | « chrome/browser/extensions/api/mdns/mdns_api_unittest.cc ('k') | chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc » ('j') | chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

index 6a3a503df017448026d75b70275e478a21e73dce..7bc876aec02efd29d4fb2af0aeb633f34d813df9 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

@@ -7,6 +7,7 @@

#include "base/command_line.h"

#include "base/logging.h"

+#include "base/memory/scoped_ptr.h"

#include "chrome/browser/extensions/extension_apitest.h"

#include "components/keyed_service/core/keyed_service.h"

#include "components/onc/onc_constants.h"

@@ -276,10 +277,10 @@ class NetworkingPrivateApiTest : public ExtensionApiTest {

}

- static KeyedService* GetNetworkingPrivateDelegate(

+ static scoped_ptr<KeyedService> GetNetworkingPrivateDelegate(

content::BrowserContext* profile) {

CHECK(s_test_delegate_);

- return s_test_delegate_;

+ return make_scoped_ptr(s_test_delegate_);

}

void SetUpCommandLine(base::CommandLine* command_line) override {