chrome/browser/extensions/active_script_controller_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/active_script_controller_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_ui_controller_unittest.cc ('k') | chrome/browser/extensions/api/audio_modem/audio_modem_api_unittest.cc » ('j') | chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/active_script_controller_unittest.cc

diff --git a/chrome/browser/extensions/active_script_controller_unittest.cc b/chrome/browser/extensions/active_script_controller_unittest.cc

index 3f191ade29dd803ed39b749363749c9b8562a96b..497077d4bb9849d60685e4e77652653968bf922f 100644

--- a/chrome/browser/extensions/active_script_controller_unittest.cc

+++ b/chrome/browser/extensions/active_script_controller_unittest.cc

@@ -32,11 +32,6 @@ namespace {

const char kAllHostsPermission[] = "*://*/*";

-// We skip syncing for testing purposes.

-KeyedService* BuildSyncService(content::BrowserContext* context) {

- return nullptr;

} // namespace

// Unittests for the ActiveScriptController mostly test the internal logic

@@ -169,8 +164,9 @@ void ActiveScriptControllerUnitTest::IncrementExecutionCount(

void ActiveScriptControllerUnitTest::SetUp() {

ChromeRenderViewHostTestHarness::SetUp();

- ExtensionSyncServiceFactory::GetInstance()->SetTestingFactory(

- profile(), &BuildSyncService);

+ // Skip syncing for testing purposes.

+ ExtensionSyncServiceFactory::GetInstance()->SetTestingFactory(profile(),

+ nullptr);

TabHelper::CreateForWebContents(web_contents());

TabHelper* tab_helper = TabHelper::FromWebContents(web_contents());