extensions/renderer/resources/guest_view/web_view/web_view_action_requests.js - Issue 1165773004: Extract the element implementation logic to function mods in <webview>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/web_view/web_view_action_requests.js

Issue 1165773004: Extract the element implementation logic to function mods in <webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@qui

Patch Set: rename all attachWindow -> attachWindow$ Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/resources/guest_view/web_view/web_view.js ('k') | extensions/renderer/resources/guest_view/web_view/web_view_iframe.js » ('j') | extensions/renderer/resources/guest_view/web_view/web_view_iframe.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/guest_view/web_view/web_view_action_requests.js

diff --git a/extensions/renderer/resources/guest_view/web_view/web_view_action_requests.js b/extensions/renderer/resources/guest_view/web_view/web_view_action_requests.js

index f5be50aecd571bd4fa838a9dc9c3a14656e5989b..9cf2c9a42b29ee77a5b8705e38e6eee5388892dc 100644

--- a/extensions/renderer/resources/guest_view/web_view/web_view_action_requests.js

+++ b/extensions/renderer/resources/guest_view/web_view/web_view_action_requests.js

@@ -163,7 +163,7 @@ NewWindow.prototype.getInterfaceObject = function() {

webViewImpl.onAttach(this.event.partition);

}

- var attached = webViewImpl.attachWindow(this.event.windowId);

+ var attached = webViewImpl.attachWindow$(this.event.windowId);

if (!attached) {

window.console.error(ERROR_MSG_NEWWINDOW_UNABLE_TO_ATTACH);

}