extensions/renderer/resources/guest_view/extension_options/extension_options.js - Issue 1165773004: Extract the element implementation logic to function mods in <webview>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/extension_options/extension_options.js

Issue 1165773004: Extract the element implementation logic to function mods in <webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@qui

Patch Set: fix comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/resources/guest_view/app_view/app_view.js ('k') | extensions/renderer/resources/guest_view/extension_view/extension_view.js » ('j') | extensions/renderer/resources/guest_view/guest_view_container.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/guest_view/extension_options/extension_options.js

diff --git a/extensions/renderer/resources/guest_view/extension_options/extension_options.js b/extensions/renderer/resources/guest_view/extension_options/extension_options.js

index d96a130ce75c91c606679618f208328ef8281564..7193607fabb089b8374d7c09bbd3defc8cbae0b8 100644

--- a/extensions/renderer/resources/guest_view/extension_options/extension_options.js

+++ b/extensions/renderer/resources/guest_view/extension_options/extension_options.js

@@ -41,7 +41,7 @@ ExtensionOptionsImpl.prototype.createGuest = function() {

var createFailedEvent = new Event('createfailed', { bubbles: true });

this.dispatchEvent(createFailedEvent);

} else {

- this.attachWindow();

+ this.attachWindow$();

}

}.bind(this));

};