Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: extensions/renderer/resources/guest_view/surface_view/surface_view.js

Issue 1165773004: Extract the element implementation logic to function mods in <webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@qui
Patch Set: sync @tott Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This module implements the SurfaceView prototype. 5 // This module implements the SurfaceView prototype.
6 6
7 var GuestView = require('guestView').GuestView; 7 var GuestView = require('guestView').GuestView;
8 var GuestViewContainer = require('guestViewContainer').GuestViewContainer; 8 var GuestViewContainer = require('guestViewContainer').GuestViewContainer;
9 9
10 function SurfaceViewImpl(surfaceviewElement) { 10 function SurfaceViewImpl(surfaceviewElement) {
(...skipping 24 matching lines...) Expand all
35 callback(false); 35 callback(false);
36 } 36 }
37 return; 37 return;
38 } 38 }
39 39
40 this.url = url; 40 this.url = url;
41 41
42 this.guest.destroy(); 42 this.guest.destroy();
43 43
44 this.guest.create(this.buildParams(), function() { 44 this.guest.create(this.buildParams(), function() {
45 this.attachWindow(); 45 this.attachWindow$();
46 if (callback) { 46 if (callback) {
47 callback(true); 47 callback(true);
48 } 48 }
49 }.bind(this)); 49 }.bind(this));
50 }; 50 };
51 51
52 GuestViewContainer.registerElement(SurfaceViewImpl); 52 GuestViewContainer.registerElement(SurfaceViewImpl);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698