Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 11649037: Fix several bugs in error stack trace formatting. (Closed)

Created:
8 years ago by Yang
Modified:
8 years ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Fix several bugs in error stack trace formatting. GetScriptWrapper can be called recursively: GetScriptWrapper -> GC -> DeferredFormatStackTrace -> GetScriptWrapper GC-unsafe code in ErrorObjectList::DeferredFormatStackTrace Enable overwriting Error.prepareStackTrace by itself while not causing infinity recursion when it triggers an exception. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13256

Patch Set 1 #

Patch Set 2 : changed GetScriptWrapper fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -31 lines) Patch
M src/handles.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/heap.cc View 1 1 chunk +27 lines, -22 lines 0 comments Download
M src/messages.js View 2 chunks +13 lines, -6 lines 0 comments Download
M test/mjsunit/stack-traces.js View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
8 years ago (2012-12-20 15:57:39 UTC) #1
ulan
8 years ago (2012-12-20 16:23:38 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698