Issue 11649018: Remove Utf8InputBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11649018: Remove Utf8InputBuffer (Closed)

Created:
8 years ago by drcarney

Modified:
8 years ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove Utf8InputBuffer R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13248

Patch Set 1 #

Total comments: 3

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+237 lines, -160 lines)			Patch
M	src/debug-agent.cc	View	1 chunk	+6 lines, -13 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+16 lines, -22 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/objects.cc	View	4 chunks	+57 lines, -47 lines	1 comment	Download
M	src/scanner.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/unicode.h	View	4 chunks	+38 lines, -14 lines	0 comments	Download
M	src/unicode.cc	View	2 chunks	+69 lines, -52 lines	1 comment	Download
M	src/unicode-inl.h	View	1 chunk	+46 lines, -4 lines	1 comment	Download
M	test/cctest/test-regexp.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years ago (2012-12-20 09:20:27 UTC) #1

LGTM. Will land with comments fixed.

https://codereview.chromium.org/11649018/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/11649018/diff/1/src/objects.cc#newcode7901
src/objects.cc:7901: utf16_length += is_two_byte ? 2 : 1;
is_two_byte is a misnomer?

https://codereview.chromium.org/11649018/diff/1/src/unicode-inl.h
File src/unicode-inl.h (right):

https://codereview.chromium.org/11649018/diff/1/src/unicode-inl.h#newcode282
src/unicode-inl.h:282: return length;
no line break here.

https://codereview.chromium.org/11649018/diff/1/src/unicode.cc
File src/unicode.cc (right):

https://codereview.chromium.org/11649018/diff/1/src/unicode.cc#newcode330
src/unicode.cc:330: if (is_two_byte) {
misnomer?

Expand Messages | Collapse Messages