Issue 11649010: Add ResolveProxy to the content API

Issue 11649010: Add ResolveProxy to the content API (Closed)

Created:
8 years ago by raymes

Modified:
8 years ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add ResolveProxy to the content API. Currently the pepper_flash_renderer_host.cc is in content/ but brettw informs me that Flash-related hosts should live in chrome/. To do this ResolveProxy needs to be added to the content API. The host will be moved out of content/ in the next CL. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173874

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -8 lines)			Patch
M	content/public/renderer/render_thread.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/public/test/mock_render_thread.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/test/mock_render_thread.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_flash_renderer_host.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	content/renderer/render_thread_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/renderer/webplugin_delegate_proxy.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm https://codereview.chromium.org/11649010/diff/2001/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/11649010/diff/2001/content/renderer/render_thread_impl.cc#newcode71 content/renderer/render_thread_impl.cc:71: #include "googleurl/src/gurl.h" nit: don't include this, it's a ...

8 years ago (2012-12-19 01:39:39 UTC) #2

raymes

https://codereview.chromium.org/11649010/diff/2001/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/11649010/diff/2001/content/renderer/render_thread_impl.cc#newcode71 content/renderer/render_thread_impl.cc:71: #include "googleurl/src/gurl.h" On 2012/12/19 01:39:39, John Abd-El-Malek wrote: > ...

8 years ago (2012-12-19 02:59:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/11649010/6002

8 years ago (2012-12-19 02:59:43 UTC) #4

Message was sent while issue was closed.

Change committed as 173874

Expand Messages | Collapse Messages