Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3945)

Unified Diff: cc/picture_layer_impl.cc

Issue 11649005: cc: Support anti-aliasing for solid color layers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and add DrawQuad::AntiAliasing struct. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/picture_layer_impl.cc
diff --git a/cc/picture_layer_impl.cc b/cc/picture_layer_impl.cc
index 161fd83cc54471c0a627b2479b5912ace15cac79..533a0a7a3bb625220db984510f4bc86d9bc2087c 100644
--- a/cc/picture_layer_impl.cc
+++ b/cc/picture_layer_impl.cc
@@ -83,6 +83,11 @@ void PictureLayerImpl::appendQuads(QuadSink& quadSink,
gfx::Rect geometry_rect = iter.geometry_rect();
+ bool outside_left_edge = geometry_rect.x() == content_rect.x();
+ bool outside_top_edge = geometry_rect.y() == content_rect.y();
+ bool outside_right_edge = geometry_rect.right() == content_rect.right();
+ bool outside_bottom_edge = geometry_rect.bottom() == content_rect.bottom();
+
if (!resource) {
if (drawCheckerboardForMissingTiles()) {
// TODO(enne): Figure out how to show debug "invalidated checker" color
@@ -93,7 +98,12 @@ void PictureLayerImpl::appendQuads(QuadSink& quadSink,
appendQuadsData.numMissingTiles++;
} else {
scoped_ptr<SolidColorDrawQuad> quad = SolidColorDrawQuad::Create();
- quad->SetNew(sharedQuadState, geometry_rect, backgroundColor());
+ quad->SetNew(sharedQuadState, geometry_rect,
+ DrawQuad::AntiAliasing(outside_left_edge && useAA,
+ outside_top_edge && useAA,
+ outside_right_edge && useAA,
+ outside_bottom_edge && useAA),
+ backgroundColor());
if (quadSink.append(quad.PassAs<DrawQuad>(), appendQuadsData))
appendQuadsData.numMissingTiles++;
}
@@ -104,23 +114,18 @@ void PictureLayerImpl::appendQuads(QuadSink& quadSink,
gfx::Rect opaque_rect = iter->opaque_rect();
opaque_rect.Intersect(content_rect);
- bool outside_left_edge = geometry_rect.x() == content_rect.x();
- bool outside_top_edge = geometry_rect.y() == content_rect.y();
- bool outside_right_edge = geometry_rect.right() == content_rect.right();
- bool outside_bottom_edge = geometry_rect.bottom() == content_rect.bottom();
-
scoped_ptr<TileDrawQuad> quad = TileDrawQuad::Create();
quad->SetNew(sharedQuadState,
geometry_rect,
opaque_rect,
+ DrawQuad::AntiAliasing(outside_left_edge && useAA,
+ outside_top_edge && useAA,
+ outside_right_edge && useAA,
+ outside_bottom_edge && useAA),
resource,
texture_rect,
iter.texture_size(),
- iter->contents_swizzled(),
- outside_left_edge && useAA,
- outside_top_edge && useAA,
- outside_right_edge && useAA,
- outside_bottom_edge && useAA);
+ iter->contents_swizzled());
quadSink.append(quad.PassAs<DrawQuad>(), appendQuadsData);
}
}

Powered by Google App Engine
This is Rietveld 408576698