Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 11649004: Allow access to chrome:// URLs for component apps. (Closed)

Created:
8 years ago by Gaurav
Modified:
7 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, asargent_no_longer_on_chrome
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Allow access to chrome:// URLs for component apps. BUG=149036 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174021

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/renderer_host/chrome_render_view_host_observer.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Gaurav
8 years ago (2012-12-18 22:57:11 UTC) #1
jam
On 2012/12/18 22:57:11, Gaurav wrote: see chrome/OWNERS you should also have someone familiar with extensions ...
8 years ago (2012-12-19 01:35:18 UTC) #2
Gaurav
8 years ago (2012-12-19 18:39:35 UTC) #3
asargent_no_longer_on_chrome
lgtm https://chromiumcodereview.appspot.com/11649004/diff/1/chrome/browser/renderer_host/chrome_render_view_host_observer.cc File chrome/browser/renderer_host/chrome_render_view_host_observer.cc (right): https://chromiumcodereview.appspot.com/11649004/diff/1/chrome/browser/renderer_host/chrome_render_view_host_observer.cc#newcode84 chrome/browser/renderer_host/chrome_render_view_host_observer.cc:84: // Allow access to chrome:// URLs for component ...
8 years ago (2012-12-19 18:50:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/11649004/6001
8 years ago (2012-12-19 20:38:03 UTC) #5
commit-bot: I haz the power
Change committed as 174021
8 years ago (2012-12-19 22:42:58 UTC) #6
cevans
On 2012/12/19 22:42:58, I haz the power (commit-bot) wrote: > Change committed as 174021 This ...
7 years, 11 months ago (2013-01-24 09:15:41 UTC) #7
asargent_no_longer_on_chrome
Hey Chris- It's not clear to me how this causes a security regression, since this ...
7 years, 11 months ago (2013-01-24 17:58:16 UTC) #8
Nico
Gaurav: I've never seen this CL before cevans's comment. When you TBR a change against ...
7 years, 11 months ago (2013-01-24 18:20:18 UTC) #9
asargent_no_longer_on_chrome
thakis - my apologies - Gaurav's new to the team and I should have noticed ...
7 years, 11 months ago (2013-01-24 18:43:29 UTC) #10
asargent_no_longer_on_chrome
7 years, 11 months ago (2013-01-24 19:03:53 UTC) #11
(hopefully last update from me here)

I just talked with Chris and I see the attack vector now, and we'll discuss
in a new bug entry the right way to fix it.



On Thu, Jan 24, 2013 at 10:43 AM, Antony Sargent <asargent@chromium.org>wrote:

> thakis -  my apologies - Gaurav's new to the team and I should have
> noticed the inappropriate use of TBR here.
>
>
> On Thu, Jan 24, 2013 at 10:20 AM, <thakis@chromium.org> wrote:
>
>> Gaurav: I've never seen this CL before cevans's comment. When you TBR a
>> change
>> against me, always add me to the reviewers line and hit "publish+mail
>> comments"
>> so that I see the CL. Do not TBR cls with actual code changes against me,
>> only
>> simple gypi changes. For other stuff wait for an explicit lgtm from me.
>>
>> (I likely wouldn't have caught what cevans complains about though.)
>>
>>
https://chromiumcodereview.**appspot.com/11649004/<https://chromiumcodereview...
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698