Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 11648009: Android buildbot: Add missing @@@ echo to 'bb_run_unit_tests' (Closed)

Created:
8 years ago by digit1
Modified:
8 years ago
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Android buildbot: Add missing @@@ echo to 'bb_run_unit_tests' Without this, a failure in this function is mistakenly reported as a failure in the previous bb_xxxxx function called. For example, see the following link where the failure is reported in 'bb_reboot_phones' when it should not: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/23/steps/Rebooting%20phones/logs/stdio BUG=none NOTRY=true TBR=yfriedman@chromium.org,ilevy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173895

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M build/android/buildbot/buildbot_functions.sh View 1 5 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
No comments yet.
8 years ago (2012-12-19 10:56:47 UTC) #1
Philippe
On 2012/12/19 10:56:47, I haz the power (commit-bot) wrote: > No comments yet. lgtm
8 years ago (2012-12-19 10:57:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/11648009/1
8 years ago (2012-12-19 10:57:49 UTC) #3
commit-bot: I haz the power
Change committed as 173895
8 years ago (2012-12-19 11:07:56 UTC) #4
digit1
Please disregard Patch set 2, it was mistakenly uploaded to this issue, its correct location ...
8 years ago (2012-12-19 12:06:30 UTC) #5
Yaron
8 years ago (2012-12-19 18:21:43 UTC) #6
Message was sent while issue was closed.
patchset 1 lgtm

Powered by Google App Engine
This is Rietveld 408576698