Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 11647050: mac: attempt to fix a startup perf regression after r174653 (Closed)

Created:
7 years, 12 months ago by Nico
Modified:
7 years, 11 months ago
Reviewers:
sail
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

mac: attempt to fix a startup perf regression after r174653 BUG=168084 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175123

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -16 lines) Patch
M chrome/browser/ui/cocoa/image_button_cell.h View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/image_button_cell.mm View 1 2 3 4 4 chunks +36 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
This is for r174653. It's pretty ugly unfortunately :-/
7 years, 11 months ago (2013-01-04 01:32:01 UTC) #1
sail
LGTM https://codereview.chromium.org/11647050/diff/7001/chrome/browser/ui/cocoa/image_button_cell.h File chrome/browser/ui/cocoa/image_button_cell.h (right): https://codereview.chromium.org/11647050/diff/7001/chrome/browser/ui/cocoa/image_button_cell.h#newcode26 chrome/browser/ui/cocoa/image_button_cell.h:26: enum ImageType { It doesn't seem like you ...
7 years, 11 months ago (2013-01-04 05:27:24 UTC) #2
Nico
https://codereview.chromium.org/11647050/diff/7001/chrome/browser/ui/cocoa/image_button_cell.h File chrome/browser/ui/cocoa/image_button_cell.h (right): https://codereview.chromium.org/11647050/diff/7001/chrome/browser/ui/cocoa/image_button_cell.h#newcode26 chrome/browser/ui/cocoa/image_button_cell.h:26: enum ImageType { On 2013/01/04 05:27:24, sail wrote: > ...
7 years, 11 months ago (2013-01-04 05:52:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/11647050/11001
7 years, 11 months ago (2013-01-04 05:55:20 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 08:31:21 UTC) #5
Message was sent while issue was closed.
Change committed as 175123

Powered by Google App Engine
This is Rietveld 408576698