Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 11647031: Renamed MessageViewMultiple to NotificationView (Closed)

Created:
8 years ago by dharcourt
Modified:
7 years, 11 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, miket_OOO
Visibility:
Public.

Description

Renamed MessageViewMultiple to NotificationView MessageViewMultiple -> NotificationView to reflect its soon-to-be more general role displaying basic and image notifications in addition to multiple item notifications. BUG=164292 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175102

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -227 lines) Patch
M ui/message_center/message_center.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/message_center/message_view_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D ui/message_center/message_view_multiple.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/message_center/message_view_multiple.cc View 1 chunk +0 lines, -183 lines 0 comments Download
A ui/message_center/notification_view.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
A + ui/message_center/notification_view.cc View 1 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dharcourt
8 years ago (2012-12-20 05:25:30 UTC) #1
Jun Mukai
lgtm
8 years ago (2012-12-20 18:10:10 UTC) #2
Jun Mukai
https://codereview.chromium.org/11647031/diff/1/ui/message_center/notification_view.h File ui/message_center/notification_view.h (right): https://codereview.chromium.org/11647031/diff/1/ui/message_center/notification_view.h#newcode15 ui/message_center/notification_view.h:15: // TODO(dharcourt): Rename MessageCenter and MessageView* to NotificationCenter can ...
8 years ago (2012-12-20 18:21:21 UTC) #3
dharcourt
https://codereview.chromium.org/11647031/diff/1/ui/message_center/notification_view.h File ui/message_center/notification_view.h (right): https://codereview.chromium.org/11647031/diff/1/ui/message_center/notification_view.h#newcode15 ui/message_center/notification_view.h:15: // TODO(dharcourt): Rename MessageCenter and MessageView* to NotificationCenter On ...
8 years ago (2012-12-20 20:38:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/11647031/4001
7 years, 11 months ago (2013-01-03 16:58:13 UTC) #5
commit-bot: I haz the power
Failed to apply patch for ui/message_center/notification_view.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; A ui/message_center/notification_view.cc ...
7 years, 11 months ago (2013-01-03 16:58:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/11647031/4001
7 years, 11 months ago (2013-01-04 02:31:18 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 04:44:51 UTC) #8
Message was sent while issue was closed.
Change committed as 175102

Powered by Google App Engine
This is Rietveld 408576698