Renamed MessageViewMultiple to NotificationView

Renamed MessageViewMultiple to NotificationView

MessageViewMultiple -> NotificationView to reflect its soon-to-be more
general role displaying basic and image notifications in addition to
multiple item notifications.

BUG=164292
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175102

[Jun Mukai, 2012-12-20 18:10:10]

lgtm

[Jun Mukai, 2012-12-20 18:21:21]

https://codereview.chromium.org/11647031/diff/1/ui/message_center/notificatio...
File ui/message_center/notification_view.h (right):

https://codereview.chromium.org/11647031/diff/1/ui/message_center/notificatio...
ui/message_center/notification_view.h:15: // TODO(dharcourt): Rename
MessageCenter and MessageView* to NotificationCenter
can you update this TODO btw?

[dharcourt, 2012-12-20 20:38:29]

https://codereview.chromium.org/11647031/diff/1/ui/message_center/notificatio...
File ui/message_center/notification_view.h (right):

https://codereview.chromium.org/11647031/diff/1/ui/message_center/notificatio...
ui/message_center/notification_view.h:15: // TODO(dharcourt): Rename
MessageCenter and MessageView* to NotificationCenter
On 2012/12/20 18:21:21, Jun Mukai wrote:
> can you update this TODO btw?

Done.

[commit-bot: I haz the power, 2013-01-03 16:58:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dharcourt@chromium.org/11647031/4001

[commit-bot: I haz the power, 2013-01-03 16:58:18]

Failed to apply patch for ui/message_center/notification_view.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         ui/message_center/notification_view.cc
  Copied ui/message_center/message_view_multiple.cc ->
ui/message_center/notification_view.cc
  patching file ui/message_center/notification_view.cc
  Hunk #2 succeeded at 52 with fuzz 2 (offset 3 lines).
  Hunk #3 FAILED at 92.
  1 out of 3 hunks FAILED -- saving rejects to file
ui/message_center/notification_view.cc.rej

Patch:   NR 
ui/message_center/message_view_multiple.cc->ui/message_center/notification_view.cc
Index: ui/message_center/notification_view.cc
diff --git a/ui/message_center/message_view_multiple.cc
b/ui/message_center/notification_view.cc
similarity index 93%
rename from ui/message_center/message_view_multiple.cc
rename to ui/message_center/notification_view.cc
index
e6c32c46dcb58c9e23f4c7b865eb3cdc505dfe3e..7e61402ce9860494ae86704ad3bd186b3fb94871
100644
--- a/ui/message_center/message_view_multiple.cc
+++ b/ui/message_center/notification_view.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "ui/message_center/message_view_multiple.h"
+#include "ui/message_center/notification_view.h"
 
 #include "base/utf_string_conversions.h"
 #include "grit/ui_resources.h"
@@ -49,8 +49,8 @@ views::Border* MakePadding(int top, int left, int bottom, int
right) {
   return views::Border::CreateEmptyBorder(top, left, bottom, right);
 }
 
-// ItemViews are responsible for drawing each MessageViewMultiple item's title
-// and message next to each other within a single column.
+// ItemViews are responsible for drawing each NotificationView item's title and
+// message next to each other within a single column.
 class ItemView : public views::View {
  public:
   ItemView(const message_center::NotificationList::NotificationItem& item);
@@ -92,18 +92,16 @@ ItemView::~ItemView() {
 
 namespace message_center {
 
-MessageViewMultiple::MessageViewMultiple(
+NotificationView::NotificationView(
     NotificationList::Delegate* list_delegate,
     const NotificationList::Notification& notification)
     : MessageView(list_delegate, notification) {
 }
 
-MessageViewMultiple::~MessageViewMultiple() {
+NotificationView::~NotificationView() {
 }
 
-// TODO(dharcourt): Make this a subclass of BaseFormatView or of a
-// BaseFormatView superclass and leverage that class' SetUpView().
-void MessageViewMultiple::SetUpView() {
+void NotificationView::SetUpView() {
   set_background(views::Background::CreateSolidBackground(kBackgroundColor));
 
   views::GridLayout* layout = new views::GridLayout(this);

[commit-bot: I haz the power, 2013-01-04 02:31:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dharcourt@chromium.org/11647031/4001

[commit-bot: I haz the power, 2013-01-04 04:44:51]

Change committed as 175102