Close avatar bubble when avatar button is clicked a second time

chrome/browser/ui/views/avatar_menu_bubble_view.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_AVATAR_MENU_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_AVATAR_MENU_BUBBLE_VIEW_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 12 matching lines @@
 class Separator;
 }
 
 // This bubble view is displayed when the user clicks on the avatar button.
 // It displays a list of profiles and allows users to switch between profiles.
 class AvatarMenuBubbleView : public views::BubbleDelegateView,
                              public views::ButtonListener,
                              public views::LinkListener,
                              public AvatarMenuModelObserver {
  public:
-  AvatarMenuBubbleView(views::View* anchor_view,
-                       views::BubbleBorder::ArrowLocation arrow_location,
-                       const gfx::Rect& anchor_rect,
-                       Browser* browser);
+  // Helper function to show the bubble and ensure that it doesn't reshow.
+  // Normally this bubble is shown when there's a mouse down event on a button.
+  // If the bubble is already showing when the user clicks on the button then
+  // this will cause two things to happen:
+  // - (1) the button will show a new instance of the bubble
+  // - (2) the old instance of the bubble will get a deactivate event and
+  //   close
+  // To prevent this reshow this function checks if an instance of the bubble
+  // is already showing and do nothing. This means that (1) will do nothing
+  // and (2) will correctly hide the old bubble instance.
+  static void ShowBubble(views::View* anchor_view,
+                         views::BubbleBorder::ArrowLocation arrow_location,
+                         views::BubbleBorder::BubbleAlignment border_alignment,
+                         const gfx::Rect& anchor_rect,
+                         Browser* browser);
+  static bool IsShowing();
+  static void Hide();
+
   virtual ~AvatarMenuBubbleView();
 
   // views::View implementation.
   virtual gfx::Size GetPreferredSize() OVERRIDE;
   virtual void Layout() OVERRIDE;
   virtual bool AcceleratorPressed(const ui::Accelerator& accelerator) OVERRIDE;
 
   // views::ButtonListener implementation.
   virtual void ButtonPressed(views::Button* sender,
                              const ui::Event& event) OVERRIDE;
 
   // views::LinkListener implementation.
   virtual void LinkClicked(views::Link* source, int event_flags) OVERRIDE;
 
   // BubbleDelegate implementation.
   virtual gfx::Rect GetAnchorRect() OVERRIDE;
   virtual void Init() OVERRIDE;
+  virtual void WindowClosing() OVERRIDE;
 
   // AvatarMenuModelObserver implementation.
   virtual void OnAvatarMenuModelChanged(
       AvatarMenuModel* avatar_menu_model) OVERRIDE;
 
  private:
+  AvatarMenuBubbleView(views::View* anchor_view,
+                       views::BubbleBorder::ArrowLocation arrow_location,
+                       const gfx::Rect& anchor_rect,
+                       Browser* browser);
+
   views::Link* add_profile_link_;
   scoped_ptr<AvatarMenuModel> avatar_menu_model_;
   gfx::Rect anchor_rect_;
   Browser* browser_;
   std::vector<views::CustomButton*> item_views_;
   views::Separator* separator_;
 
+  static AvatarMenuBubbleView* avatar_bubble_;
+
   DISALLOW_COPY_AND_ASSIGN(AvatarMenuBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_AVATAR_MENU_BUBBLE_VIEW_H_