Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 11645042: Disable ContentViewPopupZoomerTest.testPopupZoomerShowsUp test. (Closed)

Created:
8 years ago by digit1
Modified:
8 years ago
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Disable ContentViewPopupZoomerTest.testPopupZoomerShowsUp test. NOTRY=true BUG=167045 TBR=yfriedman@chromium.org,ilevy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/android/gtest_filter/content_unittests_disabled View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
digit1
I'm disabling this test for now to turn the bots green. Didn't find the reason ...
8 years ago (2012-12-20 11:57:25 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years ago (2012-12-20 11:57:54 UTC) #2
felipeg
LGTM
8 years ago (2012-12-20 12:07:47 UTC) #3
Peter Beverloo
lgtm Please be sure to cc the people working on the disambiguation popup on the ...
8 years ago (2012-12-20 12:08:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/11645042/1
8 years ago (2012-12-20 12:22:11 UTC) #5
commit-bot: I haz the power
Change committed as 174145
8 years ago (2012-12-20 12:22:18 UTC) #6
digit1
8 years ago (2012-12-20 12:23:03 UTC) #7
Message was sent while issue was closed.
Thanks, I've added aruslan to this issue, will add him to the bug too.

Powered by Google App Engine
This is Rietveld 408576698