Try again to land the improved owners algorithm.

Try again to land the improved owners algorithm.

Initially landed in r173784, reverted in r173808

R=maruel@chromium.org
BUG=76727
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=173979

[Dirk Pranke, 2012-12-19 01:03:15]

Please take another look? The initial rev is the patch that landed; the diff in
rev 2 has the fix and a new test.

[M-A Ruel, 2012-12-19 01:41:45]

lgtm with optional nit

https://codereview.chromium.org/11645009/diff/1001/owners.py
File owners.py (right):

https://codereview.chromium.org/11645009/diff/1001/owners.py#newcode282
owners.py:282: if not current_dir in [el[0] for el in
all_possible_owners[owner]]:
if would be efficient to do:
if not any(current_dir == el[0] for el in all_possible_owners[owner]):

[Dirk Pranke, 2012-12-19 02:20:09]

On 2012/12/19 01:41:45, Marc-Antoine Ruel wrote:
> lgtm with optional nit
> 
> https://codereview.chromium.org/11645009/diff/1001/owners.py
> File owners.py (right):
> 
> https://codereview.chromium.org/11645009/diff/1001/owners.py#newcode282
> owners.py:282: if not current_dir in [el[0] for el in
> all_possible_owners[owner]]:
> if would be efficient to do:
> if not any(current_dir == el[0] for el in all_possible_owners[owner]):

I don't think the efficiency matters in this case, but it is probably slightly
clearer. Will do.

[commit-bot: I haz the power, 2012-12-19 20:10:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/11645009/8001

[commit-bot: I haz the power, 2012-12-19 20:13:34]

Change committed as 173979