Issue 11644097: Use C++ style type casts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11644097: Use C++ style type casts. (Closed)

Created:
8 years ago by Yang

Modified:
7 years, 11 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use C++ style type casts. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13326

Patch Set 1 #

Total comments: 3

Patch Set 2 : addressed comments #

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -50 lines)			Patch
M	src/arm/simulator-arm.cc	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/conversions-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap-inl.h	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/mark-compact.cc	View	1 2	4 chunks	+16 lines, -16 lines	0 comments	Download
M	src/mips/assembler-mips.cc	View	1 2	10 chunks	+17 lines, -14 lines	0 comments	Download
M	src/mips/constants-mips.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/ic-mips.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips/simulator-mips.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/objects.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

7 years, 11 months ago (2013-01-07 14:36:31 UTC) #2

LGTM with comments.

https://codereview.chromium.org/11644097/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

https://codereview.chromium.org/11644097/diff/1/src/arm/simulator-arm.cc#newc...
src/arm/simulator-arm.cc:3087: dst,
static_cast<double>(reinterpret_cast<uint32_t>(val)));
Shouldn't this be a static_cast?

https://codereview.chromium.org/11644097/diff/1/src/arm/simulator-arm.cc#newc...
src/arm/simulator-arm.cc:3094: dst,
static_cast<float>(reinterpret_cast<uint32_t>(val)));
Likewise.

https://codereview.chromium.org/11644097/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/11644097/diff/1/test/cctest/test-heap.cc#newc...
test/cctest/test-heap.cc:168: HEAP->NumberFromUint32(static_cast<uint32_t>(1) <<
31);
Should fit into one line.

Expand Messages | Collapse Messages