chrome/common/extensions/manifest_handler.h - Issue 11644057: Move BrowserAction out of Extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handler.h

Issue 11644057: Move BrowserAction out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_ungoop_extension_action

Patch Set: Combined ActionInfo wrappers Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/manifest_handler.h

diff --git a/chrome/common/extensions/manifest_handler.h b/chrome/common/extensions/manifest_handler.h

index 3a15b9513542598e0ad4bc818e877faa1288214f..942381d7df4441601de3760a22fe22712afa6330 100644

--- a/chrome/common/extensions/manifest_handler.h

+++ b/chrome/common/extensions/manifest_handler.h

@@ -34,9 +34,7 @@ class ManifestHandler {

// not present in the manifest.

// Returns true on success or false on failure; if false, |error| will

// be set to a failure message.

- virtual bool HasNoKey(Extension* extension, string16* error) {

- return true;

- }

+ virtual bool HasNoKey(Extension* extension, string16* error);

// Associate |handler| with |key| in the manifest. Takes ownership

// of |handler|. TODO(yoz): Decide how to handle dotted subkeys.