chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc - Issue 11644057: Move BrowserAction out of Extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

Issue 11644057: Move BrowserAction out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_ungoop_extension_action

Patch Set: Combined ActionInfo wrappers Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/extension_action/action_info.h ('K') | « chrome/common/extensions/api/extension_action/script_badge_handler.cc ('k') | chrome/common/extensions/api/omnibox/omnibox_handler.cc » ('j') | chrome/common/extensions/manifest_tests/extension_manifests_pageaction_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

index 299fda2d10e69ad6f190f1ffe4b5c20698a8a925..d316f2e1836b1f22a155fc9ff73dcbbe18f4db6d 100644

--- a/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

+++ b/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

@@ -58,7 +58,7 @@ TEST_F(ScriptBadgeManifestTest, ScriptBadgeBasic) {

.Build());

ASSERT_TRUE(extension.get());

const ActionInfo* script_badge_info =

- ScriptBadgeInfo::GetScriptBadge(extension);

+ ActionInfoData::GetScriptBadgeInfo(extension);

ASSERT_TRUE(script_badge_info);

EXPECT_THAT(StripMissingFlagWarning(extension->install_warnings()),

testing::ElementsAre(/*empty*/));

@@ -98,7 +98,7 @@ TEST_F(ScriptBadgeManifestTest, ScriptBadgeExplicitTitleAndIconsIgnored) {

.Build());

ASSERT_TRUE(extension.get());

const ActionInfo* script_badge_info =

- ScriptBadgeInfo::GetScriptBadge(extension);

+ ActionInfoData::GetScriptBadgeInfo(extension);

ASSERT_TRUE(script_badge_info);

EXPECT_THAT(StripMissingFlagWarning(extension->install_warnings()),

@@ -136,7 +136,7 @@ TEST_F(ScriptBadgeManifestTest, ScriptBadgeIconFallsBackToPuzzlePiece) {

.Build());

ASSERT_TRUE(extension.get());

const ActionInfo* script_badge_info =

- ScriptBadgeInfo::GetScriptBadge(extension);

+ ActionInfoData::GetScriptBadgeInfo(extension);

ASSERT_TRUE(script_badge_info);

EXPECT_THAT(extension->install_warnings(),

testing::ElementsAre(/*empty*/));