Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5414)

Unified Diff: chrome/common/extensions/api/extension_action/action_info.cc

Issue 11644057: Move BrowserAction out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_ungoop_extension_action
Patch Set: Combined ActionInfo wrappers Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_action/action_info.cc
diff --git a/chrome/common/extensions/api/extension_action/action_info.cc b/chrome/common/extensions/api/extension_action/action_info.cc
index b1c3d7af7b5a0d8d12d36672f70e99bf0ba4fa9c..ff40f068623a84b383f2e7a618b51cc1aacc12a8 100644
--- a/chrome/common/extensions/api/extension_action/action_info.cc
+++ b/chrome/common/extensions/api/extension_action/action_info.cc
@@ -3,10 +3,38 @@
// found in the LICENSE file.
#include "chrome/common/extensions/api/extension_action/action_info.h"
+#include "chrome/common/extensions/extension_manifest_constants.h"
namespace extensions {
+namespace {
+
+static const ActionInfo* GetActionInfo(const Extension* extension,
+ const std::string& key) {
+ ActionInfoData* data = static_cast<ActionInfoData*>(
+ extension->GetManifestData(key));
+ return data ? data->action_info.get() : NULL;
+}
+
+} // namespace
+
ActionInfo::ActionInfo() {}
ActionInfo::~ActionInfo() {}
+ActionInfoData::ActionInfoData(ActionInfo* info) : action_info(info) {
+}
+
+ActionInfoData::~ActionInfoData() {
+}
+
+const ActionInfo* ActionInfoData::GetBrowserActionInfo(
+ const Extension* extension) {
+ return GetActionInfo(extension, extension_manifest_keys::kBrowserAction);
+}
+
+const ActionInfo* ActionInfoData::GetScriptBadgeInfo(
+ const Extension* extension) {
+ return GetActionInfo(extension, extension_manifest_keys::kScriptBadge);
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698