Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Side by Side Diff: chrome/common/extensions/extension_file_util.cc

Issue 11644057: Move BrowserAction out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_ungoop_extension_action
Patch Set: Combined ActionInfo wrappers Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_file_util.h" 5 #include "chrome/common/extensions/extension_file_util.h"
6 6
7 #include <map> 7 #include <map>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/file_path.h" 10 #include "base/file_path.h"
11 #include "base/file_util.h" 11 #include "base/file_util.h"
12 #include "base/files/scoped_temp_dir.h" 12 #include "base/files/scoped_temp_dir.h"
13 #include "base/json/json_file_value_serializer.h" 13 #include "base/json/json_file_value_serializer.h"
14 #include "base/logging.h" 14 #include "base/logging.h"
15 #include "base/metrics/histogram.h" 15 #include "base/metrics/histogram.h"
16 #include "base/path_service.h" 16 #include "base/path_service.h"
17 #include "base/stringprintf.h" 17 #include "base/stringprintf.h"
18 #include "base/threading/thread_restrictions.h" 18 #include "base/threading/thread_restrictions.h"
19 #include "base/utf_string_conversions.h" 19 #include "base/utf_string_conversions.h"
20 #include "chrome/common/chrome_constants.h" 20 #include "chrome/common/chrome_constants.h"
21 #include "chrome/common/chrome_paths.h" 21 #include "chrome/common/chrome_paths.h"
22 #include "chrome/common/extensions/api/extension_action/action_info.h" 22 #include "chrome/common/extensions/api/extension_action/action_info.h"
23 #include "chrome/common/extensions/api/extension_action/browser_action_handler.h "
23 #include "chrome/common/extensions/extension.h" 24 #include "chrome/common/extensions/extension.h"
24 #include "chrome/common/extensions/extension_l10n_util.h" 25 #include "chrome/common/extensions/extension_l10n_util.h"
25 #include "chrome/common/extensions/extension_manifest_constants.h" 26 #include "chrome/common/extensions/extension_manifest_constants.h"
26 #include "chrome/common/extensions/extension_messages.h" 27 #include "chrome/common/extensions/extension_messages.h"
27 #include "chrome/common/extensions/extension_resource.h" 28 #include "chrome/common/extensions/extension_resource.h"
28 #include "chrome/common/extensions/message_bundle.h" 29 #include "chrome/common/extensions/message_bundle.h"
29 #include "grit/generated_resources.h" 30 #include "grit/generated_resources.h"
30 #include "net/base/escape.h" 31 #include "net/base/escape.h"
31 #include "net/base/file_stream.h" 32 #include "net/base/file_stream.h"
32 #include "ui/base/l10n/l10n_util.h" 33 #include "ui/base/l10n/l10n_util.h"
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 } 329 }
329 } 330 }
330 331
331 const extensions::ActionInfo* action = extension->page_action_info(); 332 const extensions::ActionInfo* action = extension->page_action_info();
332 if (action && !action->default_icon.empty() && 333 if (action && !action->default_icon.empty() &&
333 !ValidateExtensionIconSet(action->default_icon, extension, 334 !ValidateExtensionIconSet(action->default_icon, extension,
334 IDS_EXTENSION_LOAD_ICON_FOR_PAGE_ACTION_FAILED, error)) { 335 IDS_EXTENSION_LOAD_ICON_FOR_PAGE_ACTION_FAILED, error)) {
335 return false; 336 return false;
336 } 337 }
337 338
338 action = extension->browser_action_info(); 339 action = extensions::ActionInfoData::GetBrowserActionInfo(extension);
339 if (action && !action->default_icon.empty() && 340 if (action && !action->default_icon.empty() &&
340 !ValidateExtensionIconSet(action->default_icon, extension, 341 !ValidateExtensionIconSet(action->default_icon, extension,
341 IDS_EXTENSION_LOAD_ICON_FOR_BROWSER_ACTION_FAILED, error)) { 342 IDS_EXTENSION_LOAD_ICON_FOR_BROWSER_ACTION_FAILED, error)) {
342 return false; 343 return false;
343 } 344 }
344 345
345 // Validate that background scripts exist. 346 // Validate that background scripts exist.
346 for (size_t i = 0; i < extension->background_scripts().size(); ++i) { 347 for (size_t i = 0; i < extension->background_scripts().size(); ++i) {
347 if (!file_util::PathExists( 348 if (!file_util::PathExists(
348 extension->GetResource( 349 extension->GetResource(
(...skipping 405 matching lines...) Expand 10 before | Expand all | Expand 10 after
754 return FilePath(); 755 return FilePath();
755 } 756 }
756 return temp_path; 757 return temp_path;
757 } 758 }
758 759
759 void DeleteFile(const FilePath& path, bool recursive) { 760 void DeleteFile(const FilePath& path, bool recursive) {
760 file_util::Delete(path, recursive); 761 file_util::Delete(path, recursive);
761 } 762 }
762 763
763 } // namespace extension_file_util 764 } // namespace extension_file_util
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698