cc: Don't let invalidations that we're going to handle immediately cause an extra commit.

cc: Don't let invalidations that we're going to handle immediately cause an extra commit.

Tests:
LayerTreeHostTestNoExtraCommitFromInvalidate.runSingleThread
LayerTreeHostTestNoExtraCommitFromInvalidate.runMultiThread

R=enne
BUG=166715
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174073

[danakj, 2012-12-20 01:06:48]

https://codereview.chromium.org/11644036/diff/4001/cc/layer.h
File cc/layer.h (right):

https://codereview.chromium.org/11644036/diff/4001/cc/layer.h#newcode324
cc/layer.h:324: // When true, the layer about to perform an update. Any
invalidations will
self nit: "the layer *is* about to"

[enne (OOO), 2012-12-20 01:15:33]

I really wish we could just clear setNeedsCommit after update, but sometimes we
get invalidations during paint (thanks, WebKit) that we need to care about.

https://codereview.chromium.org/11644036/diff/4001/cc/layer.h
File cc/layer.h (right):

https://codereview.chromium.org/11644036/diff/4001/cc/layer.h#newcode327
cc/layer.h:327: bool m_insidePreUpdate;
naming bikeshed: m_insidePreUpdate => m_ignoreSetNeedsCommit

...and then maybe just have setNeedsCommit handle this logic, since that's
really what you're preventing?

[danakj, 2012-12-20 01:18:02]

https://codereview.chromium.org/11644036/diff/4001/cc/layer.h
File cc/layer.h (right):

https://codereview.chromium.org/11644036/diff/4001/cc/layer.h#newcode327
cc/layer.h:327: bool m_insidePreUpdate;
On 2012/12/20 01:15:33, enne wrote:
> naming bikeshed: m_insidePreUpdate => m_ignoreSetNeedsCommit
> 
> ...and then maybe just have setNeedsCommit handle this logic, since that's
> really what you're preventing?

Hmm... okay. I thought about it and then thought what if something really does
need to cause a commit. But.. then the commit will happen now anyways, so okay!

[danakj, 2012-12-20 01:22:54]

Done. PTAL

[enne (OOO), 2012-12-20 01:27:35]

lgtm

[danakj, 2012-12-20 01:42:27]

thanks :)

[commit-bot: I haz the power, 2012-12-20 01:42:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11644036/12001

[commit-bot: I haz the power, 2012-12-20 01:42:43]

Change committed as 174073