cc: Invalidate the full tiled layer when contents scale changes.

cc: Invalidate the full tiled layer when contents scale changes.

Previously we invalidated only the area outside of the previous
bounds, but this is incorrect when changing the scale.

The verifyInvalidationWhenContentsScaleChanges test was not actually
testing to make sure invalidation happened, so fixed the test to do
its job.

Tests:
TiledLayerTest.verifyInvalidationWhenContentsScaleChanges

BUG=166715
R=enne
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174042

[enne (OOO), 2012-12-19 23:57:24]

lgtm

https://codereview.chromium.org/11644035/diff/1/cc/tiled_layer.cc
File cc/tiled_layer.cc (right):

https://codereview.chromium.org/11644035/diff/1/cc/tiled_layer.cc#newcode637
cc/tiled_layer.cc:637: ContentsScalingLayer::update(queue, occlusion, stats);
You should do this in ScrollbarLayer too (but not PictureLayer).

[trchen, 2012-12-19 23:59:56]

Confirmed. This fixes bug 166715

[commit-bot: I haz the power, 2012-12-20 00:09:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11644035/6001

[commit-bot: I haz the power, 2012-12-20 00:09:32]

Change committed as 174042

[klobag.chromium, 2012-12-20 00:40:58]

https://chromiumcodereview.appspot.com/11644035/diff/6001/cc/tiled_layer.cc
File cc/tiled_layer.cc (right):

https://chromiumcodereview.appspot.com/11644035/diff/6001/cc/tiled_layer.cc#n...
cc/tiled_layer.cc:637: ContentsScalingLayer::update(queue, occlusion, stats);
Should this be after updateBounds()?

[danakj, 2012-12-20 00:52:28]

https://chromiumcodereview.appspot.com/11644035/diff/6001/cc/tiled_layer.cc
File cc/tiled_layer.cc (right):

https://chromiumcodereview.appspot.com/11644035/diff/6001/cc/tiled_layer.cc#n...
cc/tiled_layer.cc:637: ContentsScalingLayer::update(queue, occlusion, stats);
On 2012/12/20 00:40:58, klobag.chromium wrote:
> Should this be after updateBounds()?

This is acting as the ContentsScalingLayer's version of updating. Other layers
than tiled layer (eg scrolbar) also inherit from ContentsScalingLayer, and they
should call its update() and have it do the same thing.

Whereas updateBounds() is a TiledLayer specific thing.