Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4553)

Unified Diff: chrome/browser/instant/instant_controller.cc

Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/instant/instant_controller.h ('k') | chrome/browser/instant/instant_extended_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/instant/instant_controller.cc
diff --git a/chrome/browser/instant/instant_controller.cc b/chrome/browser/instant/instant_controller.cc
index 86db17b4540fe6fa85b7333ed1802c7000341702..70e0a6031b5d5f316fc38ea405b709d8dafdd1ec 100644
--- a/chrome/browser/instant/instant_controller.cc
+++ b/chrome/browser/instant/instant_controller.cc
@@ -1106,14 +1106,18 @@ void InstantController::StopCapturingKeyStrokes(
void InstantController::NavigateToURL(const content::WebContents* contents,
const GURL& url,
- content::PageTransition transition) {
+ content::PageTransition transition,
+ WindowOpenDisposition disposition) {
+ LOG_INSTANT_DEBUG_EVENT(this, base::StringPrintf(
+ "NavigateToURL: url='%s'", url.spec().c_str()));
+
// TODO(samarth): handle case where contents are no longer "active" (e.g. user
// has switched tabs).
if (!extended_enabled_)
return;
if (overlay_)
HideOverlay();
- browser_->OpenURLInCurrentTab(url, transition);
+ browser_->OpenURL(url, transition, disposition);
}
void InstantController::OmniboxLostFocus(gfx::NativeView view_gaining_focus) {
« no previous file with comments | « chrome/browser/instant/instant_controller.h ('k') | chrome/browser/instant/instant_extended_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698