Allow NPAPI & Trusted Broker plugins access to OS-level HighDPI APIs

Allow NPAPI & Trusted Broker plugins access to OS-level HighDPI APIs.

As per crrev.com/10069029, OS 10.7.3 and above report low-DPI to
processes that lack an NSPrincipalClass key in their manifest.  Because
Chromium Helper processes lacked this key, NPAPI or Trusted Broker
plugins they hosted could not use the OS HighDPI APIs.

This CL adds the key to Chromium's Helper process plist, so that APIs
such as -[NSScreen backingScaleFactor] will now return 2 under HighDPI.

Note that NPAPI plugins still can't paint HighDPI surfaces yet because
chrome doesn't implement the NPAPI ContentsScaleFactor specification
(see crbug.com/31960).

BUG=167209
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174811

[Wez, 2012-12-21 01:01:11]

PTAL

[Nico, 2012-12-21 22:27:36]

The CL description is misguiding. I'd say

"Give NPAPI plugins a NSPrincipalClass entry, giving them access to some hidpi
apis.

NPAPI plugins can't paint hidpi surfaces yet because chrome doesn't implement
the hidpi
npapi functions (it does implement this for ppapi however). However,
-[NSScreen backingScaleFactor] will now return 2 for example."

I'd remove 31960 from the BUG line as this doesn't have to do too much with that
bug.


Did you check if this affects npapi flash at all?


Also +stuart as he has a better sense if changes like this might trip up
plugins.

[wez1, 2012-12-21 23:44:51]

On 2012/12/21 22:27:36, Nico wrote:
> The CL description is misguiding. I'd say
> 
> "Give NPAPI plugins a NSPrincipalClass entry, giving them access to some hidpi
> apis.
> 
> NPAPI plugins can't paint hidpi surfaces yet because chrome doesn't implement
> the hidpi
> npapi functions (it does implement this for ppapi however). However,
> -[NSScreen backingScaleFactor] will now return 2 for example."
> 
> I'd remove 31960 from the BUG line as this doesn't have to do too much with
that
> bug.
> 
> 
> Did you check if this affects npapi flash at all?
> 
> 
> Also +stuart as he has a better sense if changes like this might trip up
> plugins.

Have updated description based on your suggestions; let me know if you'd like
any further changes.

I've run NPAPI Flash under a Chromium build w/ this patch and observed no change
in behaviour.

[stuartmorgan, 2012-12-31 09:02:28]

LGTM. I wouldn't expect any plugins would be negatively impacted (but as I noted
in the bug, the benefits here are minimal as well).

[commit-bot: I haz the power, 2012-12-31 09:37:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/11642052/1

[commit-bot: I haz the power, 2012-12-31 09:37:09]

Presubmit check for 11642052-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/app
    content/shell

[Nico, 2013-01-02 15:11:24]

chrome lgtm

+avi for content/

[Avi (use Gerrit), 2013-01-02 15:34:02]

lgtm

stampety stamp

[commit-bot: I haz the power, 2013-01-02 15:40:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/11642052/1

[commit-bot: I haz the power, 2013-01-02 18:02:29]

Change committed as 174811