content/browser/download/save_package_unittest.cc - Issue 11642041: Don't allow '\0' characters in FilePath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_package_unittest.cc

Issue 11642041: Don't allow '\0' characters in FilePath. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: resize -> reserve in SavePackageTest Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/save_package_unittest.cc

diff --git a/content/browser/download/save_package_unittest.cc b/content/browser/download/save_package_unittest.cc

index 89fb89a9f7df566cafbf4579fa494cefc66d04e6..a34e138c1c94c765548acc96caedeb7d9bc6602d 100644

--- a/content/browser/download/save_package_unittest.cc

+++ b/content/browser/download/save_package_unittest.cc

@@ -109,7 +109,7 @@ class SavePackageTest : public RenderViewHostImplTestHarness {

temp_dir_.path().AppendASCII("testfile_files"));

// We need to construct a path that is *almost* kMaxFilePathLength long

- long_file_name.resize(kMaxFilePathLength + long_file_name.length());

aedla 2013/01/28 11:40:15 Looks like reserve was intended here. Because othe

+ long_file_name.reserve(kMaxFilePathLength + long_file_name.length());

while (long_file_name.length() < kMaxFilePathLength)

long_file_name += long_file_name;

long_file_name.resize(

« no previous file with comments | « base/file_path_unittest.cc ('k') | ipc/ipc_message_utils.cc » ('j') | no next file with comments »