Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2949)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 11642014: Re-introduce the partial magnifier (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review fix (comment #4) Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index 529b78d898656ede28c5fcd34e498dcd65d25f9a..ca142de89a97b8186344eb92218d08884d577620 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -85,6 +85,7 @@
#endif
#if defined(OS_CHROMEOS)
+#include "ash/magnifier/magnifier_constants.h"
#include "chrome/browser/chromeos/accessibility/accessibility_util.h"
#include "chrome/browser/chromeos/extensions/wallpaper_manager_util.h"
#include "chrome/browser/chromeos/login/user_manager.h"
@@ -427,6 +428,22 @@ void BrowserOptionsHandler::GetLocalizedValues(DictionaryValue* values) {
values->SetString("accessibilityLearnMoreURL",
chrome::kChromeAccessibilityHelpURL);
+
+ // Creates magnifierList.
+ base::ListValue* magnifierList = new base::ListValue();
Dan Beam 2013/01/11 00:34:23 nit: magnifier_list (C++ is var_name not varName)
+ base::ListValue* option_full = new base::ListValue();
+ option_full->Append(base::Value::CreateIntegerValue(ash::MAGNIFIER_FULL));
Dan Beam 2013/01/11 00:34:23 nit: I think base::Value::Create* functions are de
+ option_full->Append(new base::StringValue(l10n_util::GetStringUTF16(
+ IDS_OPTIONS_SETTINGS_ACCESSIBILITY_SCREEN_MAGNIFIER_FULL)));
+ base::ListValue* option_partial = new base::ListValue();
+ option_partial->Append(base::Value::CreateIntegerValue(
+ ash::MAGNIFIER_PARTIAL));
+ option_partial->Append(new base::StringValue(l10n_util::GetStringUTF16(
+ IDS_OPTIONS_SETTINGS_ACCESSIBILITY_SCREEN_MAGNIFIER_PARTIAL)));
+ magnifierList->Append(option_full);
Dan Beam 2013/01/11 00:34:23 totally optional nit: I'd put some visual separati
+ magnifierList->Append(option_partial);
+ values->Set("magnifierList", magnifierList);
+
#endif
#if defined(OS_MACOSX)
values->SetString("macPasswordsWarning",

Powered by Google App Engine
This is Rietveld 408576698