Issue 11641006: Valgrind: Fix TSAN suppression syntax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11641006: Valgrind: Fix TSAN suppression syntax. (Closed)

Created:
8 years ago by Lei Zhang

Modified:
8 years ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Valgrind: Fix TSAN suppression syntax. TBR=timurrrr NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174307

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/valgrind/tsan/suppressions_win32.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11641006/1

8 years ago (2012-12-21 01:08:05 UTC) #2

Timur Iskhodzhanov

8 years ago (2012-12-21 08:35:47 UTC) #4

LGTM

Am I right that the suppression generator generated a wrong suppression?

Timur Iskhodzhanov,
Google Russia




2012/12/21 <thestig@chromium.org>

> Reviewers: Timur Iskhodzhanov,
>
> Message:
> TBR. I think the buildbot gave me bad advice.
>
> Description:
> Valgrind: Fix TSAN suppression syntax.
>
> TBR=timurrrr
> NOTRY=true
>
> Please review this at
https://codereview.chromium.**org/11641006/<https://codereview.chromium.org/1...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>   M     tools/valgrind/tsan/**suppressions_win32.txt
>
>
> Index: tools/valgrind/tsan/**suppressions_win32.txt
> ==============================**==============================**=======
> --- tools/valgrind/tsan/**suppressions_win32.txt  (revision 174296)
> +++ tools/valgrind/tsan/**suppressions_win32.txt  (working copy)
> @@ -202,7 +202,7 @@
>    ThreadSanitizer:Race
>    fun:google_breakpad::**CrashGenerationServer::~**CrashGenerationServer
>    fun:google_breakpad::**CrashGenerationServer::`scalar deleting
> destructor'
> -  fun:base::DefaultDeleter::**operator()
> +  fun:base::DefaultDeleter*
>    fun:base::internal::scoped_**ptr_impl::~scoped_ptr_impl
>    fun:remoting::**BreakpadWinDeathTest::~**BreakpadWinDeathTest
>    fun:remoting::**BreakpadWinDeathTest_**TestAccessViolation_Test::`**scalar
> deleting destructor'
>
>
>

Expand Messages | Collapse Messages