Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1812)

Unified Diff: chrome/browser/permissions/permission_bubble_request_impl.cc

Issue 1164073005: Allow script to request durable storage permission (chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix conflicts after midi constant permission landed Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/permissions/permission_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_bubble_request_impl.cc
diff --git a/chrome/browser/permissions/permission_bubble_request_impl.cc b/chrome/browser/permissions/permission_bubble_request_impl.cc
index f6b20c17a01693b9161712381588344bf605717c..35673842210a7189905d4f7a0911b888db053c6f 100644
--- a/chrome/browser/permissions/permission_bubble_request_impl.cc
+++ b/chrome/browser/permissions/permission_bubble_request_impl.cc
@@ -49,6 +49,7 @@ gfx::VectorIconId PermissionBubbleRequestImpl::GetVectorIconId() const {
case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
#endif
case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
+ case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:
// TODO(estade): add vector icons for these.
return gfx::VectorIconId::VECTOR_ICON_NONE;
default:
@@ -79,6 +80,10 @@ int PermissionBubbleRequestImpl::GetIconID() const {
icon_id = IDR_INFOBAR_PROTECTED_MEDIA_IDENTIFIER;
break;
#endif
+ // TODO(dgrogan): Get a real icon. https://crbug.com/516069
+ case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:
+ icon_id = IDR_INFOBAR_WARNING;
+ break;
default:
NOTREACHED();
return IDR_INFOBAR_WARNING;
@@ -143,6 +148,9 @@ base::string16 PermissionBubbleRequestImpl::GetMessageTextFragment() const {
message_id = IDS_PROTECTED_MEDIA_IDENTIFIER_PERMISSION_FRAGMENT;
break;
#endif
+ case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:
+ message_id = IDS_DURABLE_STORAGE_BUBBLE_FRAGMENT;
+ break;
default:
NOTREACHED();
return base::string16();
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/permissions/permission_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698