android_webview/browser/aw_permission_manager.cc - Issue 1164073005: Allow script to request durable storage permission (chrome side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_permission_manager.cc

Issue 1164073005: Allow script to request durable storage permission (chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix conflicts after midi constant permission landed Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/aw_permission_manager.cc

diff --git a/android_webview/browser/aw_permission_manager.cc b/android_webview/browser/aw_permission_manager.cc

index 718f50cf39f88c2707defcb03053af9e2bde04e6..ff45d2076d83e0ed73f1ffb9163f49d0a03a3e7e 100644

--- a/android_webview/browser/aw_permission_manager.cc

+++ b/android_webview/browser/aw_permission_manager.cc

@@ -210,6 +210,7 @@ void AwPermissionManager::RequestPermission(

break;

case PermissionType::NOTIFICATIONS:

case PermissionType::PUSH_MESSAGING:

+ case PermissionType::DURABLE_STORAGE:

NOTIMPLEMENTED() << "RequestPermission is not implemented for "

<< static_cast<int>(permission);

callback.Run(content::PERMISSION_STATUS_DENIED);

@@ -257,6 +258,7 @@ void AwPermissionManager::CancelPermissionRequest(

break;

case PermissionType::NOTIFICATIONS:

case PermissionType::PUSH_MESSAGING:

+ case PermissionType::DURABLE_STORAGE:

NOTIMPLEMENTED() << "CancelPermission not implemented for "

<< static_cast<int>(permission);

break;

« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | no next file with comments »