Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 11640016: Fix 'Android Tests' build bot. (Closed)

Created:
8 years ago by digit1
Modified:
8 years ago
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix 'Android Tests' build bot. By default, build/android/run_tests.py looks for files under out/Debug/, which will fail when in Release builds. One has to add the --release flag when invoking the script. Introduce internal function _bb_android_run_tests to always invoke the script with the right flags, and ensure all clients use it. + Add the same flag to Release build when invoking instrumentation_tests.py BUG=none NOTRY=true TBR=yfriedman@chromium.org,ilevy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173904

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M build/android/buildbot/buildbot_functions.sh View 1 5 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
digit1
8 years ago (2012-12-19 11:59:19 UTC) #1
Philippe
LGTM, thanks David for fixing this!
8 years ago (2012-12-19 12:15:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/11640016/2001
8 years ago (2012-12-19 12:16:16 UTC) #3
commit-bot: I haz the power
Change committed as 173904
8 years ago (2012-12-19 12:16:45 UTC) #4
Yaron
lgtm
8 years ago (2012-12-19 18:18:34 UTC) #5
Isaac (away)
8 years ago (2012-12-19 22:40:45 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698