Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Issue 11639050: cc: Support mask layers in impl-side painting (Closed)

Created:
8 years ago by enne (OOO)
Modified:
8 years ago
Reviewers:
nduca
CC:
chromium-reviews, cc-bugs_chromium.org, danakj
Visibility:
Public.

Description

cc: Support mask layers in impl-side painting Mask layers just set always update their tiling to be exactly the size of the mask content bounds, so that there's exactly one tile. R=nduca@chromium.org BUG=165730 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -11 lines) Patch
M cc/layer_tree_host_common.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M cc/layer_tree_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layer_tree_impl.cc View 2 chunks +5 lines, -1 line 0 comments Download
M cc/picture_layer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/picture_layer.cc View 3 chunks +7 lines, -1 line 0 comments Download
M cc/picture_layer_impl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M cc/picture_layer_impl.cc View 6 chunks +42 lines, -4 lines 0 comments Download
M cc/picture_layer_tiling.cc View 3 chunks +1 line, -2 lines 0 comments Download
M cc/picture_layer_tiling_set.h View 2 chunks +5 lines, -2 lines 0 comments Download
M cc/picture_layer_tiling_set.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
enne (OOO)
8 years ago (2012-12-20 22:07:37 UTC) #1
enne (OOO)
Writing this patch makes me wonder if maybe we need a better mechanism than didUpdateTransforms ...
8 years ago (2012-12-20 22:09:30 UTC) #2
nduca
LGTM and maybe we should file a followup about how to do didUpdateTransforms robustly?
8 years ago (2012-12-21 01:51:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11639050/1
8 years ago (2012-12-21 17:24:29 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-21 20:24:35 UTC) #5
Message was sent while issue was closed.
Change committed as 174443

Powered by Google App Engine
This is Rietveld 408576698