views: Convert scoped_arrays to the new scoped_ptr style.

views: Convert scoped_arrays to the new scoped_ptr style.

BUG=109874
R=sky@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175790

[tfarina, 2012-12-20 15:31:19]

Hi Scott, could you review this to me?

Thanks,

[sky, 2012-12-20 17:52:16]

LGTM

[tfarina, 2012-12-20 22:14:19]

Hey Albert, Windows (as always) is complaining about these changes.

Could you take a look?

Thanks,

[awong, 2012-12-21 04:15:10]

I will need to look tomorrow, but can we hold off on the checkin of these
migrations for a week or so?  I want to give the new scoped_ptr<>
implementation a little time to bake.

On Thu, Dec 20, 2012 at 2:14 PM, <tfarina@chromium.org> wrote:

> Hey Albert, Windows (as always) is complaining about these changes.
>
> Could you take a look?
>
> Thanks,
>
>
https://codereview.chromium.**org/11639042/<https://codereview.chromium.org/1...
>

[tfarina, 2012-12-21 19:47:06]

On 2012/12/21 04:15:10, awong wrote:
> I will need to look tomorrow, but can we hold off on the checkin of these
> migrations for a week or so?  I want to give the new scoped_ptr<>
> implementation a little time to bake.
> 
Looks like it used a revision that didn't have your scoped_ptr changes.

It passed the bots now. I'm going to put this in CQ with Scott's approval.

Thanks!

[commit-bot: I haz the power, 2012-12-21 20:00:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/11639042/1

[willchan no longer on Chromium, 2012-12-21 20:03:53]

Wait, why aren't we waiting as Albert requested? He's asking to wait a
week just to make sure the new scoped_ptr changes don't have issues
that would cause it to get reverted.

On Fri, Dec 21, 2012 at 12:00 PM,  <commit-bot@chromium.org> wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/tfarina@chromium.org/11639042/1
>
>
> https://chromiumcodereview.appspot.com/11639042/

[tfarina, 2012-12-21 20:05:50]

On Fri, Dec 21, 2012 at 6:03 PM, William Chan (陈智昌)
<willchan@chromium.org> wrote:
> Wait, why aren't we waiting as Albert requested? He's asking to wait a
> week just to make sure the new scoped_ptr changes don't have issues
> that would cause it to get reverted.
>
How a week will show that? We have test coverage for this in
scoped_ptr_unittest.cc and views_unittests are green.

-- 
Thiago

[tfarina, 2012-12-21 20:07:47]

On Fri, Dec 21, 2012 at 6:05 PM, Thiago Farina <tfarina@chromium.org> wrote:
> On Fri, Dec 21, 2012 at 6:03 PM, William Chan (陈智昌)
> <willchan@chromium.org> wrote:
>> Wait, why aren't we waiting as Albert requested? He's asking to wait a
>> week just to make sure the new scoped_ptr changes don't have issues
>> that would cause it to get reverted.
>>
> How a week will show that? We have test coverage for this in
> scoped_ptr_unittest.cc and views_unittests are green.
>
OK. I'll take it off of CQ.

And try again next week.

-- 
Thiago

[awong, 2012-12-21 20:13:48]

Thanks for being understanding!  I'm being extra conservative with the
scoped_ptr<> change because it's big and because we just recently cut. I'll
let you know when it all looks good.

-A

On Fri, Dec 21, 2012 at 12:07 PM, Thiago Farina <tfarina@chromium.org>wrote:

> On Fri, Dec 21, 2012 at 6:05 PM, Thiago Farina <tfarina@chromium.org>
> wrote:
> > On Fri, Dec 21, 2012 at 6:03 PM, William Chan (陈智昌)
> > <willchan@chromium.org> wrote:
> >> Wait, why aren't we waiting as Albert requested? He's asking to wait a
> >> week just to make sure the new scoped_ptr changes don't have issues
> >> that would cause it to get reverted.
> >>
> > How a week will show that? We have test coverage for this in
> > scoped_ptr_unittest.cc and views_unittests are green.
> >
> OK. I'll take it off of CQ.
>
> And try again next week.
>
> --
> Thiago
>

[tfarina, 2012-12-31 00:26:46]

Albert, Will, one week has been passed. OK to put this in CQ?

Thanks,

PS: Happy new year :)

[awong, 2012-12-31 00:29:16]

Hey Thiago,

Thanks for checking.  We were chatting on IRC about this last week friday.
I'm still thinking it's better to be conservative and wait for people to
get back in from vacation and give it a week. Since there's really no cost
to holding off on the transition, I'd rather just be safe.

Thanks for your patience.

-Albert



On Sun, Dec 30, 2012 at 4:26 PM, <tfarina@chromium.org> wrote:

> Albert, Will, one week has been passed. OK to put this in CQ?
>
> Thanks,
>
> PS: Happy new year :)
>
>
https://codereview.chromium.**org/11639042/<https://codereview.chromium.org/1...
>

[awong, 2013-01-08 23:25:14]

Okay, I think we're safe to go.  Please feel free to commit.

On 2012/12/31 00:29:16, awong wrote:
> Hey Thiago,
> 
> Thanks for checking.  We were chatting on IRC about this last week friday.
> I'm still thinking it's better to be conservative and wait for people to
> get back in from vacation and give it a week. Since there's really no cost
> to holding off on the transition, I'd rather just be safe.
> 
> Thanks for your patience.
> 
> -Albert
> 
> 
> 
> On Sun, Dec 30, 2012 at 4:26 PM, <mailto:tfarina@chromium.org> wrote:
> 
> > Albert, Will, one week has been passed. OK to put this in CQ?
> >
> > Thanks,
> >
> > PS: Happy new year :)
> >
> >
>
https://codereview.chromium.**org/11639042/%3Chttps://codereview.chromium.org...>
> >

[tfarina, 2013-01-09 00:59:28]

On 2013/01/08 23:25:14, awong wrote:
> Okay, I think we're safe to go.  Please feel free to commit.
> 
OK, cool. I'll put this in CQ tomorrow.

[commit-bot: I haz the power, 2013-01-09 11:43:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/11639042/1

[commit-bot: I haz the power, 2013-01-09 13:29:41]

Change committed as 175790