Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 11639036: Android: compile and run sandbox_linux_unittests (Closed)

Created:
8 years ago by jln (very slow on Chromium)
Modified:
8 years ago
Reviewers:
Isaac (away), nilesh
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, palmer, Jorge Lucangeli Obes, John Grabowski
Visibility:
Public.

Description

Android: compile sandbox_linux_unittests Note: tests that require kernel seccomp-bpf support to do anything will just pass if kernel support is lacking. BUG=166704 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174193

Patch Set 1 #

Patch Set 2 : Compile sandbox_linux_unittests only for now. Don't run. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/all_android.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jln (very slow on Chromium)
John, do you mind approving this? (You were listed as a contact in all_android.gyp. As ...
8 years ago (2012-12-20 09:15:27 UTC) #1
Isaac (away)
[jrg to cc, +nilesh] Hi Julien, Adding the test suite to run_tests.py will land it ...
8 years ago (2012-12-20 09:52:38 UTC) #2
nilesh
Hi Julien, We add new test suites after making sure they are stable on the ...
8 years ago (2012-12-20 17:16:19 UTC) #3
jln (very slow on Chromium)
Thanks, let's do it in steps then. PTAL, this is step1: compile sandbox_linux_unittests!
8 years ago (2012-12-20 18:15:20 UTC) #4
nilesh
LGTM
8 years ago (2012-12-20 18:20:49 UTC) #5
Isaac (away)
lgtm
8 years ago (2012-12-20 18:22:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/11639036/7001
8 years ago (2012-12-20 18:42:22 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-20 18:46:11 UTC) #8
Message was sent while issue was closed.
Change committed as 174193

Powered by Google App Engine
This is Rietveld 408576698