Try #3 to improve the owners suggesting algorithm

Try #3 to improve the owners suggesting algorithm.

This version handles the case where we need to suggest two reviewers
who have overlapping sets of directories they can review.

R=maruel@chromium.org
BUG=76727
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=174216

[Dirk Pranke, 2012-12-19 22:57:18]

third time's the charm?

[M-A Ruel, 2012-12-20 01:10:43]

lgtm

https://codereview.chromium.org/11639028/diff/6001/owners.py
File owners.py (right):

https://codereview.chromium.org/11639028/diff/6001/owners.py#newcode263
owners.py:263: dirs_to_remove = set([el[0] for el in
all_possible_owners[owner]])
dirs_remaining -= set(el[0] for el in all_possible_owners[owner])

would be just fine.

[Dirk Pranke, 2012-12-20 01:26:03]

On 2012/12/20 01:10:43, Marc-Antoine Ruel wrote:
> lgtm
> 
> https://codereview.chromium.org/11639028/diff/6001/owners.py
> File owners.py (right):
> 
> https://codereview.chromium.org/11639028/diff/6001/owners.py#newcode263
> owners.py:263: dirs_to_remove = set([el[0] for el in
> all_possible_owners[owner]])
> dirs_remaining -= set(el[0] for el in all_possible_owners[owner])
> 
> would be just fine.

Yeah, I thought the tmp var would be easier to read.

[M-A Ruel, 2012-12-20 01:30:12]

On 2012/12/20 01:26:03, Dirk Pranke wrote:
> Yeah, I thought the tmp var would be easier to read.

then remove the extra []
dirs_to_remove = set(el[0] for el in all_possible_owners[owner])

[Dirk Pranke, 2012-12-20 01:33:51]

On 2012/12/20 01:30:12, Marc-Antoine Ruel wrote:
> On 2012/12/20 01:26:03, Dirk Pranke wrote:
> > Yeah, I thought the tmp var would be easier to read.
> 
> then remove the extra []
> dirs_to_remove = set(el[0] for el in all_possible_owners[owner])

Ah, right, I didn't realize I still had that in there. Will do.

[commit-bot: I haz the power, 2012-12-20 20:12:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/11639028/3004

[commit-bot: I haz the power, 2012-12-20 20:15:00]

Change committed as 174216