Make crash bubble send onRestarted() to apps.

Make crash bubble send onRestarted() to apps.


BUG=155221
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175676

[koz (OOO until 15th September), 2012-12-21 02:44:07]

https://codereview.chromium.org/11638053/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/11638053/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.cc:711:
ReloadExtensionWithEvents(extension_id, events);
Do you know if there's a reason why these methods only send events if they had
windows open? It would simplify things if they always launched an event.

[benwells, 2012-12-21 03:48:55]

https://codereview.chromium.org/11638053/diff/1/chrome/browser/background/bac...
File chrome/browser/background/background_contents_service.cc (right):

https://codereview.chromium.org/11638053/diff/1/chrome/browser/background/bac...
chrome/browser/background/background_contents_service.cc:87: } else {
Is this meant to be if (is_platform_app_) {?

https://codereview.chromium.org/11638053/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/11638053/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.cc:714: void
ExtensionService::RestartExtension(const std::string& extension_id) {
I don't understand why RestartExtension only restarts if it has shell windows
open. I think that is incorrect, which means we can merge this with
ReloadExtensionWithRestartEvent.

[koz (OOO until 15th September), 2012-12-21 04:36:50]

https://codereview.chromium.org/11638053/diff/1/chrome/browser/background/bac...
File chrome/browser/background/background_contents_service.cc (right):

https://codereview.chromium.org/11638053/diff/1/chrome/browser/background/bac...
chrome/browser/background/background_contents_service.cc:87: } else {
On 2012/12/21 03:48:55, benwells wrote:
> Is this meant to be if (is_platform_app_) {?

Yes, yes it is. Done.

https://codereview.chromium.org/11638053/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/11638053/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service.cc:714: void
ExtensionService::RestartExtension(const std::string& extension_id) {
On 2012/12/21 03:48:55, benwells wrote:
> I don't understand why RestartExtension only restarts if it has shell windows
> open. I think that is incorrect, which means we can merge this with
> ReloadExtensionWithRestartEvent.

Done.

[koz (OOO until 15th September), 2013-01-01 23:31:29]

Ping

[Marijn Kruisselbrink, 2013-01-02 17:41:19]

On 2013/01/01 23:31:29, koz wrote:
> Ping
Sorry, was on vacation.
LGTM

[koz (OOO until 15th September), 2013-01-02 22:26:59]

On 2013/01/02 17:41:19, Marijn Kruisselbrink wrote:
> On 2013/01/01 23:31:29, koz wrote:
> > Ping
> Sorry, was on vacation.
> LGTM

No worries, thanks for the review!

[commit-bot: I haz the power, 2013-01-02 22:28:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/11638053/16001

[commit-bot: I haz the power, 2013-01-02 22:28:51]

Presubmit check for 11638053-16001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/background

Presubmit checks took 3.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[koz (OOO until 15th September), 2013-01-02 22:46:38]

+atwilson for chrome/browser/background OWNERS

[benwells, 2013-01-03 00:09:50]

lgtm

[Andrew T Wilson (Slow), 2013-01-08 08:00:21]

browser/background lgtm

[commit-bot: I haz the power, 2013-01-08 22:40:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/11638053/22001

[commit-bot: I haz the power, 2013-01-09 02:33:15]

Change committed as 175676