Issue 11638035: Set a display limit of 8 on multiple-item notifications items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11638035: Set a display limit of 8 on multiple-item notifications items. (Closed)

Created:
8 years ago by dharcourt

Modified:
7 years, 11 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews, miket_OOO

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Set a display limit of 8 on multiple-item notifications items. This limit is defined in the notification product requirement document, section "Inbox Format for Multiple Messages". The limit only affects the number of items displayed (to avoid notifications growing too tall). The back end still handles any number of items. The maximum number is declared in the public message_center_constants.h file so future code can use it, for example to output a warning or return an error if callers to the chrome.experimental.notification API ask for a notification with more than the maximum number of displayable items. BUG=161101 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175132

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
M	ui/message_center/message_center_constants.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/message_center/message_center_constants.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/message_center/notification_view.cc	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/11638035/14001

7 years, 11 months ago (2013-01-04 08:29:31 UTC) #3

Message was sent while issue was closed.

Change committed as 175132

Expand Messages | Collapse Messages

Issue 11638035: Set a display limit of 8 on multiple-item notifications items. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Messages