Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: sync/engine/get_commit_ids_command.cc

Issue 11637053: sync: Start moving away from PREV_ID and NEXT_ID (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/conflict_resolver.cc ('k') | sync/engine/process_commit_response_command_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/get_commit_ids_command.cc
diff --git a/sync/engine/get_commit_ids_command.cc b/sync/engine/get_commit_ids_command.cc
index 499723916274e67f6a02bc82a7e4143f6b5f724a..b701ea5d2d23f5470dc3c70fe7804e98a3d83dd1 100644
--- a/sync/engine/get_commit_ids_command.cc
+++ b/sync/engine/get_commit_ids_command.cc
@@ -248,7 +248,7 @@ bool GetCommitIdsCommand::AddItemThenPredecessors(
if (item.Get(syncable::IS_DEL))
return true; // Deleted items have no predecessors.
- syncable::Id prev_id = item.Get(syncable::PREV_ID);
+ syncable::Id prev_id = item.GetPredecessorId();
while (!prev_id.IsRoot()) {
syncable::Entry prev(trans, syncable::GET_BY_ID, prev_id);
CHECK(prev.good()) << "Bad id when walking predecessors.";
@@ -262,7 +262,7 @@ bool GetCommitIdsCommand::AddItemThenPredecessors(
}
if (!AddItem(ready_unsynced_set, prev, result))
return false; // Item is in conflict.
- prev_id = prev.Get(syncable::PREV_ID);
+ prev_id = prev.GetPredecessorId();
}
return true;
}
« no previous file with comments | « sync/engine/conflict_resolver.cc ('k') | sync/engine/process_commit_response_command_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698